tri11paragon
/
BLT
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix stack dynamic buffer overflow in the logging lib

v1
Brett 2023-02-08 13:14:41 -05:00
parent 3109ec13c0
commit 54fdeb1ad5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/blt/std/logging.cpp
View File

@ -61,8 +61,9 @@ namespace blt::logging {
}; };
void applyFormatting(const std::string& format, std::string& output, va_list& args){ void applyFormatting(const std::string& format, std::string& output, va_list& args){
char formattedChars[format.length()]; const char* fmt_c_str = format.c_str();
vsprintf(formattedChars, format.c_str(), args); char formattedChars[1+std::vsnprintf(nullptr, 0, fmt_c_str, args)];
vsprintf(formattedChars, fmt_c_str, args);
output = std::string(formattedChars); output = std::string(formattedChars);
} }