From 5d493a6493db429820745703c2697fcd79bbadb2 Mon Sep 17 00:00:00 2001 From: Brett Date: Sat, 4 Mar 2023 11:52:54 -0500 Subject: [PATCH] cleanup printing remove the needless addition of \n to the end of lines --- include/blt/profiling/profiler.h | 2 +- src/blt/profiling/profiler.cpp | 25 +++++++++++++++---------- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/include/blt/profiling/profiler.h b/include/blt/profiling/profiler.h index f24b539..6ef9005 100644 --- a/include/blt/profiling/profiler.h +++ b/include/blt/profiling/profiler.h @@ -54,7 +54,7 @@ namespace blt::profiling { bool averageHistory = false ); - void writeProfile(std::ofstream& out, const std::string& profileName); + void writeProfile(std::ofstream& out, const std::string& profileName, bool averageHistory = false); void discardProfiles(); diff --git a/src/blt/profiling/profiler.cpp b/src/blt/profiling/profiler.cpp index 33d0601..9a3ebe4 100644 --- a/src/blt/profiling/profiler.cpp +++ b/src/blt/profiling/profiler.cpp @@ -26,10 +26,10 @@ namespace blt::profiling { difference(difference), name(std::move(name)) {} }; - inline void print(const std::vector& lines, logging::LOG_LEVEL level) { + inline void println(const std::vector&& lines, logging::LOG_LEVEL level) { auto& logger = logging::getLoggerFromLevel(level); for (const auto& line : lines) - logger << line; + logger << line << "\n"; } /** @@ -84,8 +84,18 @@ namespace blt::profiling { } } - void writeProfile(std::ofstream& out, const std::string& profileName, bool ordered) { + void writeProfile(std::ofstream& out, const std::string& profileName, bool averageHistory) { + auto& profile = profiles[profileName]; + const auto& intervals = profile.intervals; + const auto& points = profile.points; + std::vector ordered_vector; + std::unordered_map averaged_intervals; + + if (averageHistory) + averageIntervals(profile.historicalIntervals, averaged_intervals); + + orderIntervals(averageHistory ? averaged_intervals : intervals, ordered_vector); } void printProfile( @@ -116,13 +126,8 @@ namespace blt::profiling { std::to_string((double)interval.difference / 1000000.0)} ); } - - std::vector updatedLines; - const auto& lines = formatter.createTable(true, true); - for (const auto& line : lines) - updatedLines.emplace_back(line + "\n"); - - print(updatedLines, loggingLevel); + + println(formatter.createTable(true, true), loggingLevel); } // --- small helper functions below ---